Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download links target _blank and append UI marker #192

Merged
merged 2 commits into from
May 24, 2024

Commits on May 20, 2024

  1. Download links target _blank and append UI marker

    Why are these changes being introduced:
    
    * We want to display a message in our restricted CDN auth flow that
      instructs a user to close the window/tab when the download is complete
      to return to their search if they came from TIMDEX UI.
    
    Relevant ticket(s):
    
    * https://mitlibraries.atlassian.net/browse/GDT-317
    * https://mitlibraries.atlassian.net/browse/GDT-304
    
    How does this address that need:
    
    * Adds `target=_blank` to download link tags
    * appends `?timdex-ui=true` to download link URLs
    
    Document any side effects to this change:
    
    * A bunch of tests reformatted automatically on save. The only relevant
      changes to the tests were on lines 246-247
    JPrevost committed May 20, 2024
    Configuration menu
    Copy the full SHA
    a11558c View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Handle URLs that may already have query params

    A few complex lines were moved to their own methods to make reading the method a bit easier
    JPrevost committed May 24, 2024
    Configuration menu
    Copy the full SHA
    54a2e46 View commit details
    Browse the repository at this point in the history