Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate multi-digit list markers #193

Merged
merged 1 commit into from
May 29, 2024
Merged

Commits on May 28, 2024

  1. Accommodate multi-digit list markers

    Why these changes are being introduced:
    
    The result list does not have a sufficient left margin to
    accommodate list markers that are more than one digit. Because
    of this, markers for results further down in the list are
    truncated.
    
    This issue exists on smaller viewports only. Larger viewports
    have enough space for markers up to five digits. (This is the
    maximum, in our case.)
    
    Relevant ticket(s):
    
    * [GDT-314](https://mitlibraries.atlassian.net/browse/GDT-314)
    
    How this addresses that need:
    
    This adds a left margin on smaller viewports to accommodate
    4-digit result markers, and removes the result padding to provide
    more room for text flow.
    
    Side effects of this change:
    
    * The margin is somewhat excessive for 1- or 2-digit numbers, but
    it seems like a reasonable tradeoff for now.
    * The leading digit of 5-digit numbers is still truncated. This only
    affects one possible result, and it's unlikely that a user would get
    to result 10,000.
    jazairi committed May 28, 2024
    Configuration menu
    Copy the full SHA
    10a405f View commit details
    Browse the repository at this point in the history