This repository has been archived by the owner on Oct 24, 2022. It is now read-only.
Authentication and First Draft of Authorization #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-2.73%) to 22.43% when pulling 5aed2719a5196f46f5f5ef8435d9b07604f3500c on 127_oath2 into 2c89e4f on master. |
|
Coverage increased (+0.52%) to 25.69% when pulling cd9411251d324506af639a025a1f3c9b3c46f7b6 on 127_oath2 into 2c89e4f on master. |
- Unit tests for User (user model tweaked a bit) - Authentication not tested: this is tricky and I'll get back to it closes #127 - Switch browser tests to use H2. They were still using Postgres which ran into problems for me locally. - Initial authorization / roles testing (tests just Analyst role for now which is all that exists so far) See #128 - Some IntegrationSpec tests had to be pending-ed as they require a logged in Analyst. ApplicationSpec can handle a lot of this though and it's easy to fake a Session with that type of Spec. I'll get back to this.
Handles users with expected role, lacking role, and non signed in.
- subscriber dashboard - handles users with multiple roles - redirects to trouble page with notice for authenticated users lacking required role - moved integration tests to their own directory
|
👍 |
JPrevost
added a commit
that referenced
this pull request
Apr 7, 2015
Authentication and First Draft of Authorization
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all that exists so far) See User Authorization (aka roles) #128
a Session with that type of Spec. I'll get back to this.
There's a lot more testing to be done, and definitely places where the code is really messy... but it's ready for some feedback / sanity checking.