This repository has been archived by the owner on Oct 24, 2022. It is now read-only.
158 subscriber interests #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| CREATE SEQUENCE interest_id_seq; | ||
| CREATE TABLE interest ( | ||
| id integer NOT NULL DEFAULT nextval('interest_id_seq'), |
There was a problem hiding this comment.
I would not change this, but you can simplify auto_incrementing definitions in Postgres by using the type colname SERIAL:
http://www.postgresql.org/docs/9.2/static/datatype-numeric.html#DATATYPE-SERIAL
There was a problem hiding this comment.
Yes, good point. I had started the DDL to be DB-agnostic, but there might already be some Postgresqlisms that have crept in. So why not go whole-hog?
|
👍 I think #187 will resolve my only big concern. |
richardrodgers
pushed a commit
that referenced
this pull request
Apr 29, 2015
158 subscriber interests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.