This repository has been archived by the owner on Oct 24, 2022. It is now read-only.
Prevent batch harvests from requesting invalid dates #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPrevost
force-pushed
the
240_check_date_on_batch_harvests
branch
from
d605bcc
to
75a359d
Compare
|
@richardrodgers if you happen to have time for a quick review, this should address the concern you noted. Thanks! |
This prevents batch harvests from requesting date that is older than yesterday with the assumption that it’s safest to not request an OAI feed for today as more data may be added later we’d miss. I’m not entirely sure that’s valid logic, but this is safe. The harvester increments the updated date hence the need to make sure it is less than yesterday (i.e. updated needs to be two days ago to actually run which would then get incremented by 1 to be a harvest for yesterday… clear as mud). Admin kicked off harvests and knips are not limited by date. Only the batch starter. closes #240
JPrevost
force-pushed
the
240_check_date_on_batch_harvests
branch
from
75a359d
to
d6a5136
Compare
JPrevost
added a commit
that referenced
this pull request
Jul 15, 2015
…vests Prevent batch harvests from requesting invalid dates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents batch harvests from requesting a date that is older than
yesterday with the assumption that it’s safest to not request an OAI
feed for today as more data may be added later we’d miss. I’m not
entirely sure that’s valid logic, but this seems safe. The harvester
increments the updated date hence the need to make sure it is less than
yesterday (i.e. updated needs to be two days ago to actually run which
would then get incremented by 1 to be a harvest for yesterday… clear as
mud?).
Admin kicked off harvests and knips are not limited by date. Only the
batch starter.
closes #240