Allow multiple OAuth providers to be used #295
Conversation
| auth.response.name_field="name" | ||
| auth.response.sub_field="sub" | ||
| auth.response.email_field="email" | ||
| auth.reponse.identity_provider="https://oidc.mit.edu/" |
There was a problem hiding this comment.
Oh wait, your comment made me realize that all of these values really need to be ENV overridable. Otherwise, someone needs to maintain this file out of version control or on their own fork or they won't be able to push to something like Heroku. Maybe it's worth breaking this out to it's own config file while adding in that mess of additional optional ENV overrides.
|
@richardrodgers I've updated this PR to move auth config to it's own file and allow each setting to be overridden via ENV. I'll squash the commits and merge if you are cool with this approach. If you have suggestions let me know and I'm happy to tweak further. |
|
I like it - it seems like a natural config set to carve out, and is easily included |
This provides support for Google and MIT OAuth, and thus likely others. closes #292
Allow multiple OAuth providers to be used
This provides support for Google and MIT OAuth, and thus likely others.
closes #292