This repository has been archived by the owner on Oct 24, 2022. It is now read-only.
Add deliver, discard option to hold browse view #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is what this PR does: I also considered this: I'm not sure which is better. If you feel strongly let me know :) I went with the former as I was concerned the latter may make it seem like you are acting on the Topic and not the Item. |
|
I agree with your concern about the second option - the one you chose seems better. 👍 |
JPrevost
added a commit
that referenced
this pull request
Aug 14, 2015
Add deliver, discard option to hold browse view
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #320