Skip to content
This repository has been archived by the owner on Oct 24, 2022. It is now read-only.

Adds DOI and pub date to Item show #374

Merged
merged 1 commit into from
Oct 16, 2015
Merged

Conversation

JPrevost
Copy link
Member

@JPrevost JPrevost commented Oct 5, 2015

This also removes abstract and changes the layout entirely.

closes #372

(The modified form is a bug fix I noticed while working on this and is unrelated but seemed small enough to slide in with this work).

This also removes abstract and changes the layout entirely.

closes #372
@JPrevost
Copy link
Member Author

JPrevost commented Oct 5, 2015

This is actually quite a departure for the display and thus probably deserves some discussion. As such, I've attached a screenshot:

screen shot 2015-10-05 at 12 50 11 pm

@JPrevost
Copy link
Member Author

JPrevost commented Oct 5, 2015

As you'll note in the screen shot, the following changes have been made:

  • aesthetic changes to layout
  • removed abstract
  • removed number of Transfers
  • added DOI
  • added Published date

It is entirely possible to just add DOI and Pubdate without making these changes, but once I started looking at code I could stop myself from refactoring.

The main downside I see to this is that it no longer matches the styling on every other page on the site.

@richardrodgers
Copy link
Collaborator

As you'll recall, we never got a solid recommendation from the product owning side on what metadata to display on the item page. I'd say the main thing here is to see if Katherine or others prefer this (meaning, not just addition of requested fields, but removal of abstract, etc), or at least get a reaction of some sort.
Can it be put up on staging for others to see?

@JPrevost
Copy link
Member Author

JPrevost commented Oct 5, 2015

@richardrodgers Good point. I'll work with Katharine to confirm if my assumptions of what to remove are actually desired before moving ahead (and see if anything else should go in to avoid dragging this on for months).

@JPrevost
Copy link
Member Author

@richardrodgers Katharine has signed off on this... any last thoughts before I merge?

@richardrodgers
Copy link
Collaborator

Nope - if customer is happy 👍

JPrevost added a commit that referenced this pull request Oct 16, 2015
@JPrevost JPrevost merged commit 0d5c9f9 into master Oct 16, 2015
@JPrevost JPrevost deleted the 373_additional_metadata_display branch October 16, 2015 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants