Update separators for physical_description field

* Update separators for physical_description field to improve formatting * Update fixture and unit test for more thorough testing
MITLibraries · Oct 5, 2022 · 66f084e · 66f084e
1 parent 626373d
commit 66f084e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/tests/fixtures/ead/ead_record_all_fields.xml b/tests/fixtures/ead/ead_record_all_fields.xml
@@ -68,6 +68,10 @@
                             <extent>4.5 Cubic Feet</extent>
                             <extent>(10 manuscript boxes, 1 legal manuscript box, 1 cassette box)</extent>
                         </physdesc>
+                        <physdesc>
+                            <extent>1.5 Cubic Feet</extent>
+                            <extent>(2 manuscript boxes)</extent>
+                        </physdesc>
                     </did>
                     <altformavail>
                         <head>Location of Copies</head>

diff --git a/tests/test_ead.py b/tests/test_ead.py
@@ -102,8 +102,8 @@ def test_ead_record_all_fields_transform_correctly():
             ),
         ],
         physical_description=(
-            "4.5 Cubic Feet. (10 manuscript boxes, 1 legal manuscript "
-            "box, 1 cassette box)"
+            "4.5 Cubic Feet (10 manuscript boxes, 1 legal manuscript "
+            "box, 1 cassette box); 1.5 Cubic Feet (2 manuscript boxes)"
         ),
         publication_information=[
             "Massachusetts Institute of Technology. Libraries. Department of Distinctive "

diff --git a/transmogrifier/sources/ead.py b/transmogrifier/sources/ead.py
@@ -203,11 +203,11 @@ def get_optional_fields(self, xml: Tag) -> Optional[dict]:
             "physdesc", recursive=False
         ):
             if physical_description_value := self.create_string_from_mixed_value(
-                physical_description_element, ". "
+                physical_description_element, " "
             ):
                 physical_descriptions.append(physical_description_value)
         if physical_descriptions:
-            fields["physical_description"] = ". ".join(physical_descriptions)
+            fields["physical_description"] = "; ".join(physical_descriptions)
 
         # publication_frequency field not used in EAD