Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timx 283 oaidc field method refactor #177

Merged
merged 1 commit into from
May 28, 2024

Commits on May 28, 2024

  1. Field method refactor for OaiDc and SpringshareOaiDc transforms

    Why these changes are being introduced:
    * These updates are required to implement the architecture described
    in the following ADR: https://github.com/MITLibraries/transmogrifier/blob/main/docs/adrs/0005-field-methods.md
    
    How this addresses that need:
    * Refactor base transform class OaiDc to contain get_*
    methods for optional fields
    * Make 'source_record' the first argument in OaiDc field methods
    * Move 'or None' to the return statements of field methods
    * Remove 'source_record_id' as param, replace with call inside field method instead
    * Raise SkippedRecordEvent
      * OaiDc.get_source_record_id
      * SpringshareOaiDc.get_source_link
    * Update unit tests
      * Remove OaiDc and SpringshareOaiDc record_* fixtures
    
    Side effects of this change:
    * None
    
    Relevant ticket(s):
    * https://mitlibraries.atlassian.net/browse/TIMX-283
    jonavellecuerdo committed May 28, 2024
    Configuration menu
    Copy the full SHA
    537f6ec View commit details
    Browse the repository at this point in the history