Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug #70

Closed
lyhnsn opened this issue May 17, 2024 · 1 comment
Closed

Bug #70

lyhnsn opened this issue May 17, 2024 · 1 comment

Comments

@lyhnsn
Copy link

lyhnsn commented May 17, 2024

Thank you for your excellent work.

There may be a bug, in "lib/train/actors/artrack_seq.py", line 232,

loss, status = self.compute_losses(out_dict, data)

but it should be "self.compute_sequence_losses()"? As there is no self.compute_losses in this file but in "lib/train/actors/artrack.py".

Furthermore, the input of these methods are sightly different.

Looking for you reply.

@AlexDotHam
Copy link
Collaborator

The bug you find is interesting, because i do not use the ARTrackSeq's forward function, in another way, in seq_trainer, we use the computer_sequence_loss instead of forward (or call function). Maybe i leave this just because i transfer the sequence training code from one-stage training. Moreover, thanks for your reply, i will update it when i finish the paper recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants