Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug #4 -- controls don't work #12

Closed
MJP8 opened this issue Apr 15, 2021 · 9 comments
Closed

Bug #4 -- controls don't work #12

MJP8 opened this issue Apr 15, 2021 · 9 comments
Assignees
@elijahparker @MJP8
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Adding the main OOJS.
Milestone
Todo

Comments

@MJP8
Copy link
Owner

MJP8 commented Apr 15, 2021

Describe the bug
I switched the div elements with JavaScript styles to images, but now the controls don't work.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '192.168.7.33/object/'
  2. See error

Expected behavior
I expected the images to move around like the divs used to. This is the JS (here's the HTML).

/cc @elijahparker
@MJP8 MJP8 added bug Something isn't working help wanted Extra attention is needed labels Apr 15, 2021
@MJP8 MJP8 added this to To do in Adding the main OOJS. via automation Apr 15, 2021
@MJP8 MJP8 added this to the Todo milestone Apr 15, 2021
MJP8 added a commit that referenced this issue Apr 15, 2021
@MJP8
updated files to use images for sprites. one error: #12
4bd15f9
@elijahparker
Copy link
Collaborator

It might be best just to wrap the img tag in a div, since img has less options than div.

@MJP8
Copy link
Owner Author

MJP8 commented Apr 15, 2021

I already tried that but I'll try again.

@MJP8
Copy link
Owner Author

MJP8 commented Apr 15, 2021

If I do that this is the result.

/cc @elijahparker

@MJP8
Copy link
Owner Author

MJP8 commented Apr 15, 2021

Same JS, different HTML (use the first links for JS and HTML).

@elijahparker
Copy link
Collaborator

Another option is to go back to just the div like you had before, but make the image the background image in css (and set the div to the right size for the image)

@MJP8
Copy link
Owner Author

MJP8 commented Apr 15, 2021

It didn't work. Now they are invisible.

@MJP8
Copy link
Owner Author

MJP8 commented Apr 15, 2021

Never mind. I need to specify the height too.

@MJP8
Copy link
Owner Author

MJP8 commented Apr 15, 2021 •
edited
Loading

They just won't move still.

/cc @elijahparker

MJP8 added a commit that referenced this issue Apr 24, 2021
@MJP8
fixed #12 -- needed position: absolute; in CSS
c608ab1
@MJP8
Copy link
Owner Author

MJP8 commented Apr 24, 2021

Specifying position: absolute; in the CSS worked! (c608ab1).

@MJP8 MJP8 closed this as completed Apr 24, 2021
Adding the main OOJS. automation moved this from To do to Done Apr 24, 2021
@MJP8 MJP8 mentioned this issue Apr 24, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elijahparker elijahparker

@MJP8 MJP8

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
Adding the main OOJS.
Done
Milestone
Todo
Development

No branches or pull requests
2 participants
@elijahparker @MJP8