Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom driver implementation with encapsulated RGBMatrixDriver #540

Closed
wants to merge 5 commits into from

Conversation

ty-porter
Copy link
Collaborator

@ty-porter ty-porter commented May 20, 2024

Replaces this temporary spike branch (https://github.com/MLB-LED-Scoreboard/mlb-led-scoreboard/tree/fps-counter)

New driver implementation includes display overlay or log format FPS counter

@ty-porter ty-porter added work in progress proof of concept Work that may or may not be integrated labels May 20, 2024
Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a nice clean up -- I think this needs a new addition to install.sh and requirements.txt, right?

@ty-porter
Copy link
Collaborator Author

Seems like a nice clean up -- I think this needs a new addition to install.sh and requirements.txt, right?

I think the installer is fine if you are referring to the --emulator-only flag, it's a convenience flag for skipping installation with sudo and not installing the hardware matrix driver

Requirements updated, replaced emulator with driver and appropriate stable version:

requirements.txt

@ty-porter ty-porter added dependencies Pull requests that update a dependency file and removed work in progress proof of concept Work that may or may not be integrated labels May 24, 2024
@ty-porter
Copy link
Collaborator Author

Going to close this, the driver lib I wrote works great with the emulator but the extra features break the hardware implementation. That's more work than I want to resolve at the moment

@ty-porter ty-porter closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants