New primitives added -- KNN classifier & regressor #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csala
requested changes
Nov 19, 2018
There was a problem hiding this comment.
There are a couple of things that can be removed.
However, the most important point is that there is a syntax error in the Regressor JSON.
Please correct it and later on make sure that it is valid by executing make test-all in your virtualenv and making sure that there are no errors reported.
| }, | ||
| "modalities": [], | ||
| "primitive": "sklearn.neighbors.KNeighborsClassifier", | ||
| "validation_dataset": "wine", |
There was a problem hiding this comment.
This line can be removed, as the validation method have changed.
| }, | ||
| "modalities": [], | ||
| "primitive": "sklearn.neighbors.KNeighborsClassifier", | ||
| "validation_dataset": "wine", |
| "name": "sklearn.neighbors.KNeighborsRegressor", | ||
| "author": "Sze Nga Wong (wsnalice@mit.edu)", | ||
| "documentation": "http://scikit-learn.org/stable/modules/generated/sklearn.neighbors.KNeighborsRegressor.html", | ||
| "description": "Regression based on k-nearest neighbors. The target is predicted by local interpolation of the targets associated of the nearest neighbors in the training set." |
There was a problem hiding this comment.
This line is missing a comma at the end, which makes the JSON syntax invalid. Can you add it?
| }, | ||
| "modalities": [], | ||
| "primitive": "sklearn.neighbors.KNeighborsRegressor", | ||
| "validation_dataset": "boston", |
|
Merging this in even if there are errors in it. They will be fixed afterwards in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses Issue #38