fix: replace array -> set for customMessageListeners

MLH-Fellowship · Jun 19, 2020 · 432bbce · 432bbce
1 parent ee481d5
commit 432bbce
Showing 1 changed file with 12 additions and 7 deletions.
diff --git a/packages/jest-worker/src/Farm.ts b/packages/jest-worker/src/Farm.ts
@@ -50,14 +50,17 @@ export default class Farm {
     method: string,
     ...args: Array<any>
   ): PromiseWithCustomMessage<unknown> {
-    let customMessageListeners: Array<OnCustomMessage> = [];
+    const customMessageListeners: Set<OnCustomMessage> = new Set();
 
     const addCustomMessageListener = (listener: OnCustomMessage) => {
-      customMessageListeners.push(listener);
+      customMessageListeners.add(listener);
       return () => {
-        customMessageListeners = customMessageListeners.filter(
-          customListener => customListener !== listener,
-        );
+        // Check if the following check is required
+        customMessageListeners.forEach(customListener => {
+          if (customListener === listener) {
+            customMessageListeners.delete(customListener);
+          }
+        });
       };
     };
 
@@ -84,8 +87,10 @@ export default class Farm {
           }
         };
 
-        const onEnd: OnEnd = (error: Error | null, result: unknown) =>
-          error ? reject(error) : resolve(result);
+        const onEnd: OnEnd = (error: Error | null, result: unknown) => {
+          customMessageListeners.clear();
+          return error ? reject(error) : resolve(result);
+        };
 
         const task = {onCustomMessage, onEnd, onStart, request};