Added navbar buttons + Unfinished README.md I was unable to ignore

[0xPrimata]

Why This PR Adds Value

Wanted to solve issue #50 Add Recommendations and Contact Me buttons to navbar.

What This PR Adds

Adds Recommendations and Contact Me to navbar and div ids on recommendations.html and contact.html. It also adds an unfinished README.md file which I already had locally.

• navbar.html add buttons and links to them
• recommendations.html wraps with div id="recommendations
• contact.html wraps with div id="contact"
• navbar.scss properly displays buttons to the navbar

Screenshot

How This PR Could Be Improved

css display review. #48 might have an issue #48 here if it edits how navbar displays things.

Issue This PR Closes

This closes issue #50

[netlify]

✔️ Deploy Preview for practically-pi-portfolio-template ready!

🔨 Explore the source changes: bb91cc9

🔍 Inspect the deploy log: https://app.netlify.com/sites/practically-pi-portfolio-template/deploys/60f99010bd107e00080872cd

😎 Browse the preview: https://deploy-preview-52--practically-pi-portfolio-template.netlify.app/

[0xPrimata]

@robzwolf

[louisefindlay23]

Hi, @SnowPrimate. Just responding to your Discord PM, requesting a review.

Looks great. Might be nice to add screenshots of the website and a link to the deployed web app for easy access.

The rendered MD for the directory structure looks a little strange. Not sure if it's supposed to look like this?

[0xPrimata]

That's fixed on the other branch 🤕

[dtemir]

@SnowPrimate having a little issue here when I put the browser to half of my screen. Probably caused by the fact the logo is set to the center at all times.

[0xPrimata]

@dtemir Shoot, that would also be an issue despite my modifications. I would say let's use justify-content: space-between? I'll fix that tomorrow as soon as I can, for sure before our meeting! Really late around here.

[robzwolf]

I agree with the other comments on this PR – try to fix the white gap and then I'll review this again :)

[0xPrimata]

@robzwolf I've discussed with @jagnani73 and he said that he and @dtemir are working on the white gap issue since they are working on the navbar's CSS. I'll wait for their solution and fix it from there if there is anything to be done. How should I proceed here? should I close this pull request and then PR again after their PR gets merged?

[robzwolf]

@robzwolf I've discussed with @jagnani73 and he said that he and @dtemir are working on the white gap issue since they are working on the navbar's CSS. I'll wait for their solution and fix it from there if there is anything to be done. How should I proceed here? should I close this pull request and then PR again after their PR gets merged?

There are a few acceptable approaches here. I think you should mark this pull request as a Draft one (see this guide) and then convert it to a full PR once you're ready for review.

[robzwolf]

Hey @SnowPrimate – I've marked this PR as a Draft for you.

Can you take a look at the latest version of main and work out which changes are still needed? I've a feeling a lot of this PR is perhaps no longer necessary.

[0xPrimata]

Seems like the navbar has been rebuilt, including my changes, but it has a few issues. I'll close this issue and open a new ticket to deal with those specifically.