Remove markRenderAbandoned

MLH-Fellowship · Jun 26, 2020 · 4101fd7 · 4101fd7
1 parent d3d0459
commit 4101fd7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 31 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.old.js b/packages/react-reconciler/src/ReactFiberWorkLoop.old.js
@@ -67,7 +67,6 @@ import {
   markRenderStarted,
   markRenderYielded,
   markRenderStopped,
-  markRenderAbandoned,
 } from './SchedulingProfiling';
 
 // The scheduler is imported here *only* to detect whether it's been mocked
@@ -475,18 +474,6 @@ export function scheduleUpdateOnFiber(
     return null;
   }
 
-  if (enableSchedulingProfiling) {
-    if (
-      workInProgressRoot !== null &&
-      // TODO: Confirm that this makes sense
-      !includesSomeLane(workInProgressRootRenderLanes, lane)
-      // Original criterion: expirationTime > renderExpirationTime
-      // Location: https://github.com/bvaughn/react/blob/root-event-marks/packages/react-reconciler/src/ReactFiberWorkLoop.js#L2846
-    ) {
-      markRenderAbandoned();
-    }
-  }
-
   // TODO: requestUpdateLanePriority also reads the priority. Pass the
   // priority as an argument to that function and this one.
   const priorityLevel = getCurrentPriorityLevel();

diff --git a/packages/react-reconciler/src/SchedulingProfiling.js b/packages/react-reconciler/src/SchedulingProfiling.js
@@ -118,14 +118,6 @@ export function markRenderStarted(lanes: Lanes): void {
   }
 }
 
-export function markRenderAbandoned(): void {
-  if (enableSchedulingProfiling) {
-    if (supportsUserTiming) {
-      performance.mark('--render-cancel');
-    }
-  }
-}
-
 export function markRenderYielded(): void {
   if (enableSchedulingProfiling) {
     if (supportsUserTiming) {

diff --git a/packages/react-reconciler/src/__tests__/SchedulingProfiling-test.internal.js b/packages/react-reconciler/src/__tests__/SchedulingProfiling-test.internal.js
@@ -351,11 +351,8 @@ describe('SchedulingProfiling', () => {
       expect(Scheduler).toFlushUntilNextPaint([]);
     }).toErrorDev('Cannot update during an existing state transition');
 
-    expect(marks.map(normalizeCodeLocInfo)).toEqual(
-      expect.arrayContaining([
-        '--render-cancel',
-        '--schedule-state-update-Example-1024-\n    in Example (at **)',
-      ]),
+    expect(marks.map(normalizeCodeLocInfo)).toContain(
+      '--schedule-state-update-Example-1024-\n    in Example (at **)',
     );
   });
 
@@ -381,11 +378,8 @@ describe('SchedulingProfiling', () => {
       expect(Scheduler).toFlushUntilNextPaint([]);
     }).toErrorDev('Cannot update during an existing state transition');
 
-    expect(marks.map(normalizeCodeLocInfo)).toEqual(
-      expect.arrayContaining([
-        '--render-cancel',
-        '--schedule-forced-update-Example-1024-\n    in Example (at **)',
-      ]),
+    expect(marks.map(normalizeCodeLocInfo)).toContain(
+      '--schedule-forced-update-Example-1024-\n    in Example (at **)',
     );
   });