Fix CSS rendering bug #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 11, 2015 17:13
|
Hey @bgdavidx! Thanks for the pull. Can you describe the bug in more detail? Specifically steps to recreate would be helpful. |
|
The bug was from #2 |
|
Basically, we were competing in the NoLight challenge, everybody who wrote their CSS in <style> tags ended up having it not rendered, effectively having a page with no styling applied. The problem is jQuery.html( ... ) uses an intermediate element to process the DOM nodes, some browsers such as Chrome automatically remove and tags in a
, and therefore the <style> tag ends up being in and isn't applied to the DOM. I felt this was unfair, told Nick about it, and ended up fixing it using .innerHTML (as innerHTML is JS native and won't strip anything out), and added a script re-evaluator to re-evaluate all scripts since .innerHTML won't run any injected <script> tags automatically. It works if you try the following:
Try this before and after the change, you'll notice what I'm talking about. |
|
@theycallmeswift, @bgdavidx and I talked about this at HackCU. Thanks again for the fix @bgdavidx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the rendering bug that strips out body and head when rendered.