[enhance] closure: upgraded closure compiler to r08 + fixed detected …

…errors

opabsl/jsbsl/bslDom.js

@@ -893,7 +893,7 @@ function bsldom_do_slide_out(dom, maybe_duration, maybe_easing, maybe_cb)
        var length = range.text.length;
        return normalize_obj({
            start_in:     document.elementFromPoint(range.boundingLeft, range.boundingTop),
-           finish_in:    document.elementFromPoint(range.boundingLeft + range.boundingWidth, range.boundingTop + range.offsetHeight),
+           finish_in:    document.elementFromPoint(range.boundingLeft + range.boundingWidth, range.boundingTop + range.boundingHeight),
            start_at:     offset,
            finish_at:    offset + length,
            is_collapsed: length == 0

opabsl/jsbsl/bslSession.js

@@ -405,16 +405,11 @@ var LowLevelPingLoop = {};
     /* ************************************************** */
     /* Distant Channel ********************************** */
     /**
-     * A common prototype for [ServerChannel] and [CousinChannel]
+     * A common prototype for [ServerChannel] and [ClientChannel]
      *
      * @constructor
      */
-    distantChannelprototype = {
-        message_to_post: function(message){
-            var ser = this.serialize();
-            return {to:ser,
-                    message:message};
-        },
+    var distantChannelPrototype = {
 
         /**
          * Send a message along this channel
@@ -457,6 +452,12 @@ var LowLevelPingLoop = {};
         #<End>
     }
 
+    distantChannelPrototype.message_to_post = function(message){
+        return { to: this.serialize(),
+                 message: message };
+    };
+
+
 
     /* ************************************************** */
     /* Server Channel *********************************** */
@@ -515,11 +516,11 @@ var LowLevelPingLoop = {};
          * @param msg The message, unserialized
          * @param ctx Ignored
          */
-        send: distantChannelprototype.send,
+        send: distantChannelPrototype.send,
 
-        call_no_cps: distantChannelprototype.call_no_cps,
+        call_no_cps: distantChannelPrototype.call_no_cps,
 
-        message_to_post: distantChannelprototype.message_to_post
+        message_to_post: distantChannelPrototype.message_to_post
 
     }
 
@@ -578,13 +579,13 @@ var LowLevelPingLoop = {};
          * @param The message, unserialized
          * @param ctx Ignored
          */
-        send: distantChannelprototype.send,
+        send: distantChannelPrototype.send,
 
         call_no_cps: function(){
             throw Error("Not yet implemented");
         },
 
-        message_to_post: distantChannelprototype.message_to_post
+        message_to_post: distantChannelPrototype.message_to_post
 
     }
 

opabsl/jsbsl/jQueryExtends.js

@@ -478,12 +478,11 @@ function opa_event_to_dom_event(event, name)
             if(some_mb.left) result.which = 1;
             else if(some_mb.middle) result.which = 3;
             else if(some_mb.right)  result.which = 2;
-            else
-            {
+            else if (some_mb.delta) {
                 var delta = some_mb.delta || 0;
                 result.wheelDelta = delta * 120;
                 result.detail     = - delta * 3;
-            }
+	    }
         }
     } else {
         result.which = record2obj(key_code).some;
@@ -509,7 +508,7 @@ function opa_event_to_dom_event(event, name)
     if(value_change != null)
     {
         var change = option2js(value_change);
-        if (change != null) {
+        if (change != null && change.from && change.to) {
             result.prevVal = change.from;
             result.newVal  = change.to;
         }
@@ -546,14 +545,14 @@ function tn_encaps(tn, fun){
   var types = ['DOMMouseScroll', 'mousewheel'];
   function handler (event) {
     var args = [].slice.call(arguments, 1), delta = 0, returnValue = true;
-    event = $.event.fix(event || window.event);
+    event = jQuery.event.fix(event || window.event);
     event.type = "mousewheel";
     if (event.wheelDelta) delta = event.wheelDelta / 120;
     if (event.detail) delta = - event.detail / 3;
     args.unshift(event, delta);
     event.wheelDelta = delta; // hack
-    return $.event.handle.apply(this, args); }
-  $.event.special.mousewheel = {
+    return jQuery.event.handle.apply(this, args); }
+  jQuery.event.special.mousewheel = {
     setup: function () {
       if (this.addEventListener) for (var i = types.length; i; ) this.addEventListener(types[--i], handler, false);
       else this.onmousewheel = handler; },

tools/jschecker/README

@@ -152,7 +152,7 @@ system have been added.
 
 -----
 Code in:
-lib/libtrunk_rhino_parser_jarjared.jar
+lib/rhino
 
 Rhino
 URL: http://www.mozilla.org/rhino
@@ -161,9 +161,8 @@ License:  Netscape Public License and MPL / GPL dual license
 
 Description: Mozilla Rhino is an implementation of JavaScript for the JVM.
 
-Local Modifications: None. We've used JarJar to renamespace the code
-post-compilation. See:
-http://code.google.com/p/jarjar/
+Local Modifications: Minor changes to parsing JSDoc that usually get pushed
+up-stream to Rhino trunk.
 
 
 -----
@@ -188,7 +187,7 @@ lib/guava.jar
 
 Guava Libraries
 URL: http://code.google.com/p/guava-libraries/
-Version:  R7
+Version:  r08
 License: Apache License 2.0
 
 Description: Google's core Java libraries.
@@ -210,6 +209,21 @@ Description: Annotations for software defect detection.
 Local Modifications: None.
 
 
+-----
+Code in:
+lib/jarjar.jar
+
+Jar Jar Links
+URL: http://jarjar.googlecode.com/
+Version: 1.1
+License: Apache License 2.0
+
+Description:
+A utility for repackaging Java libraries.
+
+Local Modifications: None.
+
+
 ----
 Code in:
 lib/junit.jar