Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented config options expand and useMultiGet causing issues with recurring events #9

Open
creatvty opened this issue Apr 6, 2024 · 2 comments
Labels

Comments

@creatvty
Copy link

creatvty commented Apr 6, 2024

Hey, so I have recently tried out this module and wanted to make it work together with the default calendar module. Unfortunately Recurring events never were displayed or only very sporadically.

After quite a bit of debugging I found out that by the tsdav options expand and useMultiGet for fetchCalendarObjects are enabled by default. expand causes the RRULE not to be returned for recurring events and instead those events to be expanded into individual events. Since the default calendar module depends on the rrule property to be present, these events are ignored or only a single recurrence is displayed.

Since I'm assuming the main use case for this module is to display the events in the default calendar, I would suggest to change the defaults of these properties (at least of expand) to false. Or to at least document the options, since I had to find this myself in the source code.

Or is there something I'm not seeing?
Thanks

@eouia
Copy link
Member

eouia commented Apr 8, 2024

In my memory, When I released this module, the default calendar module might have had some issues with RRULE handling. I remembered that was why the expand option default value was so.
Anyway, Your mention is right, and I'm so sorry to bother you. I'll change it soon.

@eouia eouia added the ToFix label Apr 9, 2024
@creatvty
Copy link
Author

creatvty commented Apr 9, 2024

No problem at all. Thank you for your quick response. I'm glad to help on the fix if needed.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants