docs(mf6io): standardize variable name of the feature IDs in SFR #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type changes don't need full workflow on ci
|
@jdhughes-usgs I thought it would be best to test the change for a single advanced package prior to making changes in all 4 advanced packages. Thus, I think this PR can go in pending your review and I'll submit a PR that has changes for LAK, MAW, and UZF in a separate PR. Also note that if acceptable, you may also want to accept PR #1956 over on the FloPy repo, which will overwrite the SFR dfn file there as well to keep the dfn files in sync with the change made in this PR. |
This was referenced Sep 21, 2023
jdhughes-usgs
approved these changes
Sep 21, 2023
langevin-usgs
approved these changes
Sep 21, 2023
langevin-usgs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially adjusting SFR only to see if it causes any hiccups with FloPy on ci