Implemented IPaginatedResult for supported endpoints #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No original work here. It´s basically what @YourWishes suggests in #288. Could and should be extended throughout the api for lists. Usage example: ``` const orderList: IOrder[] = []; const orderStatus = 'any'; let params = { status: orderStatus, limit: 250 }; do { const orders = await shopify.order.list(params); for (const order of orders) { orderList.push(order); } params = orders.nextPageParameters; } while (params !== undefined); console.log(`after while loop len:${orderList.length}`) ```
No original work here. It´s basically what @YourWishes suggests in #288. Could and should be extended throughout the api for lists. Usage example: ``` const orderList: IOrder[] = []; const orderStatus = 'any'; let params = { status: orderStatus, limit: 250 }; do { const orders = await shopify.order.list(params); for (const order of orders) { orderList.push(order); } params = orders.nextPageParameters; } while (params !== undefined); console.log(`after while loop len:${orderList.length}`) ```
lpinca
approved these changes
Mar 31, 2021
|
Please add |
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
@lpinca Nice catch, that isn't listed as a supported endpoint by Shopify but I just confirmed the link header is returned at that endpoint. |
|
It is called |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the continued/remaining effort to complete #447, and is also relevant to #288.
Resolves this additional request by @lpinca: