Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/bundler-friendly-lazy-imports #634

Merged
merged 1 commit into from Oct 12, 2023
Merged

fix/bundler-friendly-lazy-imports #634

merged 1 commit into from Oct 12, 2023

Conversation

reecefenwick
Copy link
Contributor

@reecefenwick reecefenwick commented Oct 9, 2023 •
edited

Changes the dynamic imports to be bundler friendly, but still remain as lazy imports.

Fixes #506

Test suite passes locally ✅
Tested this with esbuild that was previously failing ✅

Also addresses other issues out in the wild

@reecefenwick reecefenwick mentioned this pull request Oct 9, 2023
Closed
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same when pulling 70c5323 on reecefenwick:master into 6bd417f on MONEI:master.

@lpinca lpinca merged commit edf16df into MONEI:master Oct 12, 2023
7 checks passed
@lpinca
Copy link
Collaborator

lpinca commented Oct 12, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a logical approach for resource modules (ie: stop using dynamic imports)
3 participants
@reecefenwick @coveralls @lpinca