-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System log 查詢介面相關 後端 #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
我看錯 change 了,我晚點繼續看 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
問題發想,會需要 system_log_type 的 api 嗎?
麻煩請 @FWcloud916 先 rebase develop 後繼續進行開發修改,這樣才可以拿到 Mars 的 change 如果有問題都可以提出,謝謝 |
我好像越整理越亂了@@ |
11b79f6
to
af262ea
Compare
個人觀點: |
我們先將它單純化好了,先用最簡單的方式完成,未來如果有這個需求,我們再補上去,你覺得呢? |
好的 |
b1a148d
to
442e56f
Compare
@hashman 我先改這樣 麻煩看一下 |
442e56f
to
a290e63
Compare
先麻煩 @FWcloud916 針對 commit 的建議內容,另外是也幫忙 rebase 最新的 develop branch 謝謝 |
d1a8429
to
9e39a83
Compare
@hashman 好了 謝謝! |
66fcc81
to
46389ee
Compare
997754d
to
2a0f603
Compare
@hashman 加上測試了,麻煩幫我看一下,謝謝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment 的內容再麻煩 @FWcloud916 看看囉,測試的方式是正確的沒問題, Controller 沒有使用到的 function 先不要寫上去,還有些 coding style 的問題,我就沒有一一列上去了,再麻煩一併調整
謝謝
2a0f603
to
0c346b4
Compare
@hashman 好了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
這個 PR 我想應該讓你成長不少,希望你也在這個 PR 中獲得很多,花了多少時間東西就是你的,謝謝你的幫忙囉
#40 System log 查詢介面相關
add : 操作類別查詢 api
add : 操作紀錄查詢 api