Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create speaker controller #76

Merged
merged 4 commits into from
Jun 24, 2019
Merged

Conversation

xwang0929
Copy link
Collaborator

#53
先完成前後台用的 api,有些地方還需要調整,不過應該可以讓前端開始工作。

@xwang0929 xwang0929 requested a review from hashman June 24, 2019 07:53
@xwang0929 xwang0929 self-assigned this Jun 24, 2019
Copy link
Collaborator

@hashman hashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

小問題,微調一下可以先 merge 不知道下次的 PR 有沒有機會可以請 Xavier 幫忙寫個測試呢?

謝謝

app/Http/Controllers/SpeakerController.php Show resolved Hide resolved
app/Http/Controllers/SpeakerController.php Outdated Show resolved Hide resolved
database/factories/SpeakerFactory.php Outdated Show resolved Hide resolved
app/Http/Controllers/SpeakerController.php Outdated Show resolved Hide resolved
app/Http/Controllers/SpeakerController.php Outdated Show resolved Hide resolved
@xwang0929
Copy link
Collaborator Author

小問題,微調一下可以先 merge 不知道下次的 PR 有沒有機會可以請 Xavier 幫忙寫個測試呢?

謝謝

sorry, 下個 PR 會補上

@xwang0929 xwang0929 requested a review from hashman June 24, 2019 14:07
database/factories/SpeakerFactory.php Outdated Show resolved Hide resolved
@xwang0929 xwang0929 requested a review from hashman June 24, 2019 14:36
Copy link
Collaborator

@hashman hashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hashman hashman merged commit b1338d2 into MOPCON:develop Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants