Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

點擊「詳細」觸發的 api 更換、加上贊助商與講者 sidebar 入口 #92

Merged
merged 2 commits into from
Jul 12, 2019

Conversation

Tzuhui
Copy link
Collaborator

@Tzuhui Tzuhui commented Jul 11, 2019

#53 (comment)

@hashman 這兩點有做修改了~
再請 hash 幫忙 review,還有需要調整的部分再請和我說,感謝 :D

@hashman hashman self-requested a review July 12, 2019 01:41
Copy link
Collaborator

@hashman hashman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tzuhui 看一下,有些感覺上是可以 reuse 的東西,就近量用,減少在 js 中使用迴圈的行為,謝謝

resources/js/pages/speakers/speaker.vue Outdated Show resolved Hide resolved
resources/js/pages/speakers/speaker.vue Outdated Show resolved Hide resolved
resources/js/pages/speakers/speaker.vue Outdated Show resolved Hide resolved
@Tzuhui
Copy link
Collaborator Author

Tzuhui commented Jul 12, 2019

@hashman 有再調整一次~
再請幫忙 review 看看是不是這樣 XD
謝謝

@hashman
Copy link
Collaborator

hashman commented Jul 12, 2019

LGTM

@hashman hashman merged commit ac703f3 into MOPCON:develop Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants