#357: Rename property and refactor code.

* Rename object property from editable to showValuesForEditing for a better naming. * Remove unnecessary ternary operator to have the same functionality, but simpler.
MORE-Platform · May 24, 2024 · 79379da · 79379da
1 parent b0db333
commit 79379da
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/src/components/ParticipantList.vue b/src/components/ParticipantList.vue
@@ -93,7 +93,10 @@ Licensed under the Elastic License 2.0. */
       field: 'studyGroupId',
       header: t('study.props.studyGroup'),
       type: MoreTableFieldType.choice,
-      editable: { values: groupStatuses.value, editable: actionsVisible },
+      editable: {
+        values: groupStatuses.value,
+        showValuesForEditing: actionsVisible,
+      },
       sortable: true,
       filterable: { showFilterMatchModes: false },
       placeholder: t('global.placeholder.noGroup'),

diff --git a/src/components/shared/MoreTable.vue b/src/components/shared/MoreTable.vue
@@ -425,8 +425,12 @@ Licensed under the Elastic License 2.0. */
       typeof editable !== 'boolean' &&
       typeof editable !== 'function'
     ) {
-      if (Object.prototype.hasOwnProperty.call(editable, 'editable')) {
-        return (editable as MoreTableChoiceOptions).editable ?? false;
+      if (
+        Object.prototype.hasOwnProperty.call(editable, 'showValuesForEditing')
+      ) {
+        return (
+          (editable as MoreTableChoiceOptions).showValuesForEditing ?? false
+        );
       }
     }
 
@@ -673,9 +677,8 @@ Licensed under the Elastic License 2.0. */
                         column.editable as MoreTableChoiceOptions,
                       ),
                     )
-                  : column.placeholder
-                    ? column.placeholder
-                    : $t('global.placeholder.chooseDropdownOptionDefault')
+                  : column.placeholder ||
+                    $t('global.placeholder.chooseDropdownOptionDefault')
               "
             />
             <span v-else>{{

diff --git a/src/models/MoreTableModel.ts b/src/models/MoreTableModel.ts
@@ -39,7 +39,7 @@ export interface MoreTableFilterOption {
 export interface MoreTableChoiceOptions {
   values: MoreTableChoice[];
   placeholder?: string;
-  editable?: boolean;
+  showValuesForEditing?: boolean;
 }
 export interface MoreTableChoice {
   label: string;