Integrate Cleanup-Improvements #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 96dc94f.
Version & Build-Info in the Footer (2nd attempt)
…uild-id-in-the-footer Expose Build-Id also to docker-build in the ci-pipeline
…semantically correct.
…ever executed (the roleList ist hardcoded in the caller component). * Add TS exclamation mark to RadioButton role value, because it's never null.
* Add missing translations * Use vue i18n $d for date format * Remove dayjs, because we use $d instead * Use pluralization
…tion for correct date presentation.
* Use template literal instead of string concatenation. * Add more specific alert message when study update request fails (from old PR-476)
* Introduce TS interfaces for Timeline. * Do not save custom data on vue-cal Event object (only cId). * Use mapper and EventDetail object for more detailed information on e.g. dialog. * Avoid using class names in conditions for display information.
…se it should only do what it is designed/named to do. * Move logic to caller to set FE dates. * Remove logic for plannedStart date, because this logic is not running/saved in BE as well, therefore a new website refresh would undo the FE changes.
* Primevue update changes the icon to its own slot.
* Move tableActions to a slot, to reduce the complexity within the MoreTable component. * Change props setup to TS "Typing Component Props". * Rename variables to be more precise. * Move general functions to common utils. * Introduce new interfaces for better typing. * Use more typing for objects. * Remove unused CSS. * Unify repeated CSS. * Use tooltips across all action buttons (rowActions) to be consistent. * Use template literals instead of concatenations to be consistent over the code. * Use Nullish coalescing operator instead of ternary operator where it is possible, to be short and precise. * Remove complexity by removing features we do not use. * Remove unused interfaces.
* To better know what value is returned by a function, without looking into the function body logic.
…t/plannedStart/end Date in the UI immediately.
* Reduce height of Header and Footer. * Adjust MoreTabNav for better breakpoints. * Adjust buttons to be the same (especially the height) over all pages. * Fix integration container for white background. * Use Columns filter slot to translate "Apply" and "Cancel" button. * Use Buttons prop "label" for text instead of writing the text within the tags. * Add missing translation. * Explicitly define icon for FileUpload component. * Add missing ":innen" in german "Teilnehmer" translation, to be consistent over all texts.
* Do not highlight row on hover, when row is not clickable.
* To have the same behavior over all categories (observations, interventions, etc.)
…led this rule in the eslint config on global level.
…ble. * Add new dateUtils function to cut off seconds in a time string. * Add Unit test for new implemented function.
…information about the input.
* Remove vitest types, because TS throws an error not finding the types.
* Color changes to better differentiate between each state. * Add bottom border to header, to clearly see in which state the study is. * Border style dashed for preview mode and solid line for non preview states.
* We do not cut (with .split) the locale of the country anymore ("en" vs "en-GB"), because we need it to show dates.
* With the country-specific locale, we can display the correct order of the date parts (day, month & year).
* As we have defined English and German as languages, all country-specific languages are now defined for the date format.
…y has a margin-left. * This ensures the same margin over all dialogs with submit/cancel buttons.
…ponent * Otherwise an error is thrown that the translation json of the missing locale is missing (e.g. en-GB).
benitsch
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redlink-branch