Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shallow-water IC fields from periodic hex meshes #241

Merged
merged 1 commit into from Jan 31, 2019

Conversation

mgduda
Copy link
Collaborator

@mgduda mgduda commented Jan 30, 2019

This merge removes shallow-water initial conditions from periodic hex meshes.

The periodic_hex mesh generator previously added fields to the grid.nc
file to serve as placeholders for ICs for the shallow-water model.
However, these fields are not part of the MPAS mesh specification, and
have been removed. Specifically, the following fields are deleted in
this commit:

  fEdge
  fVertex
  h_s
  u
  uBC
  v
  h
  vh
  circulation
  vorticity
  ke
  tracers

Additionally, the dimensions nVertLevels and nTracers have also been
removed.

The periodic_hex mesh generator previously added fields to the grid.nc
file to serve as placeholders for ICs for the shallow-water model.
However, these fields are not part of the MPAS mesh specification, and
have been removed. Specifically, the following fields are deleted in
this commit:

  fEdge
  fVertex
  h_s
  u
  uBC
  v
  h
  vh
  circulation
  vorticity
  ke
  tracers

Additionally, the dimensions nVertLevels and nTracers have also been
removed.
@mgduda
Copy link
Collaborator Author

mgduda commented Jan 30, 2019

I'm actually not sure which MPAS cores were using the uBC field that has been removed in this PR, but in case its absence would be a problem, we could perhaps leave it in the mesh file.

@matthewhoffman
Copy link
Member

@mgduda , this looks great to me. The presence of those fields was always a minor annoyance to me. I believe that all of our cores create new mesh files from the output of periodic_hex and don't actually use the meshes it generates directly.

@mgduda mgduda merged commit 55a0fc8 into MPAS-Dev:master Jan 31, 2019
@mgduda mgduda deleted the remove_periodic_hex_ICs branch January 31, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants