-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an external script to conda-package planar_hex #256
Conversation
@matthewhoffman, could you see if this works for you? |
@matthewhoffman, my preferred way of having
or if there are packages you need that aren't in that environment, include
In either of these cases, But I think it makes sense to have the option to just run |
@xylar , thanks for addressing this. Frankly, I'd be ok with moving to the conda env approach to using tools in a workflow - I just need to get myself up to speed on that. I'm curious about why this tool ended up in the conda directory whereas all the others are still standalone scripts, but I can probably wait until next time I see you to get the explanation. |
I'd personally move all the tools to the package but I don't feel like I "own" any of them but the ones I wrote recently. I figured |
@matthewhoffman, could you test and approve this at your convenience so I can merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar , thanks for putting this together. I played around with it and it serves my need of a standalone way to run planar_hex. In the long run we can decide to what extent we want/need to support such a workflow, but for now it is very helpful.
Great, thanks for trying it out and for the helpful discussion. |
In #248,
planar_hex
was moved into the conda-package for MPAS-Tools. However there is also a need for an external version of the tool. This PR adds a stub script called planar_hex that calls the code in the conda package. (The stub script is copied from a conda environment and is the same approach used to access entry points into python packages used elsewhere.)