-
Notifications
You must be signed in to change notification settings - Fork 0
Ocean loop over tracers #4
Comments
That is a tracer update on T&S only because it is within a After the last split explicit iteration, we have:
time n+1
num_tracers so it was intentional, but poorly documented. As long as T&S are always Mark On 04/24/13 10:57, Doug Jacobsen wrote:
|
I think this should be added to our todo list. I think instead of using index_temperature and index_salinity, we should use block % state % time_levs(:) % state % dynamics_start and ... % dynamics_end though. That way, it can still be a do loop, and it will iterate over the proper "dynamics" tracers. |
I don't know if there are more instances of this. But on line 832 of mpas_ocn_time_integration_split.F, the loop that is
do 1 = 1, 2
Is intended to be over temperature, and salinity. This should be modified to use the start and end indices of the array_group (dynamics) to be more robust.
It doesn't affect the current model in a negative way, but in the future if the order of tracers are modified at all in Registry.xml, then the answer will likely be wrong.
The text was updated successfully, but these errors were encountered: