This repository has been archived by the owner on Oct 23, 2020. It is now read-only.
ALL CORES: Moving executable from src/ to the mpas root. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$(CORE)_model.exe use to get created in src/ and a symbolic link was placed in the root mpas directory. This gets confusing on some machines where the link looks like an executable, but you can't actually copy the link. The executable is moved to the MPAS root after it's build rather than linking it. Also, the .exe is removed from the executable.
ghost
assigned 
|
The clean targets need to be fixed as well in the Makefiles. |
The clean targets were not updated previously to clean the proper files
(${CORE}_model in the root directory).
This commit fixes this issue.
|
The latest commit (c840b3d) should fix the clean targets. |
|
The logic for moving the executable to the top-level directory is such that, if modifications to code are made and the model is recompiled, the new executable will stay in the src/ directory, leaving the old executable at the top-level. |
If the makefile sees src/${CORE}_model now at the end of the build, it
will move it to ./${CORE}_model
|
Take 2. I changed the logic to only attempt to move it, if the executable exists. But this should also overwrite ${CORE}_model in the top-level if it was rebuilt. |
|
Looks good now; I'll merge the pull request. |
mgduda
added a commit
that referenced
this pull request
May 2, 2013
ALL CORES: Moving executable from src/ to the mpas root.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$(CORE)_model.exe use to get created in src/ and a symbolic link was
placed in the root mpas directory. This gets confusing on some machines
where the link looks like an executable, but you can't actually copy the
link.
The executable is moved to the MPAS root after it's build rather than
linking it.
Also, the .exe is removed from the executable.
This commit fixes #2