Add a step for remapping topography from MALI #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
added
enhancement
xylar
force-pushed
the
add-mali-topo
branch
3 times, most recently
from
0b54306
to
959da20
Compare
Comparison with SOwISC12to30E3r3Here are the And the same but with BedMachine from #807: |
xylar
force-pushed
the
add-mali-topo
branch
2 times, most recently
from
be2486f
to
b5e6880
Compare
Updated Comparison with SOwISC12to30E3r3Here are the And the same but with BedMachine from #807: |
|
I was able to run the workflow through the performance test. In a discussion with @cbegeman, @matthewhoffman and @trhille, we decided we'd like to work with a 4km initial condition that's more similar to the 2km one I used in the plots above, and that that initial condition would also be swapped into E3SM-Project/E3SM#6440, the PR bringing in the new MALI AIS meshes and initial conditions. |
xylar
force-pushed
the
add-mali-topo
branch
2 times, most recently
from
e512590
to
824f8f5
Compare
During the `cull_mesh` step of creating a global ocean mesh, if ice-shelf cavities are present, we need to flood fill to make sure all land ice is connected (no islands of isolated land ice). This merge changes the flood fill to be on all locations where `landIceFraction > 0`, not all locations where `landIceFraction > 0.5`. It then masks all `landIce*` fields to only be nonzero within the flood-filled region. This prevents islands of nonzero `landIceFraction`, `landIcePressure`, `landIceDraft`, etc.
Switch SO12to60 to SO12to30 with a base resolution that is now uniformly 30 km.
When we plot histograms of the initial condition, now plot histograms of the water-column thickness in the open ocean and in cavities.
In cavities, we thicken the water column to make sure it has the minimum thickness. The hope is that this makes the vertical coorinate converge more quickly and smoothly to its final result.
MALI topogrpahy gets combined with BedMachine Antarctica/GEBCO. For now, the masks for the grounding line, calving front, etc. are form BedMachine, not MALI, so that the same horizontal mesh and mapping files can be used with BedMachine and MALI topogrpahy.
These will change the locaiton of the grounding line and calving front, so that the resulting ocean grid will be different from the equivalent from BedMachine.
Move ocean_density and sea_level to config options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MALI topography as well as masks for land ice, floating ice and ocean get combined with BedMachine Antarctica/GEBCO.
Checklist
api.rst) has any new or modified class, method and/or functions listedE3SM-Projectsubmodule has been updated with relevant E3SM changesTestingin this PR) any testing that was used to verify the changes