Do not modify the radius of the Earth #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to stay with the Earth radius from CIME used throughout compass, not the one in MPAS-Ocean.
xylar
added
ocean
clean-up
python package
|
This is a change that @proteanplanet requested quite a long time ago. We want to make sure that the CIME Earth radius is used consistently throughout the E3SM mesh generation process. This has already happened for steps that are in MPAS-Tools and compass but MPAS-Model has been renormalizing the sphere radius to its own internal value. It would still be good if MPAS-Ocean's internal Earth radius were made the same as CIME's because some parameterizations use the Earth radius form MPAS-Model. But with this change, the mesh should retain the CIME Earth radius. |
mark-petersen
approved these changes
May 4, 2021
|
Thanks @mark-petersen and @vanroekel! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to stay with the Earth radius from CIME used throughout compass, not the one in MPAS-Ocean.
closes #61