Fix/msvc_compilation #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpassy
reviewed
May 2, 2020
|
|
||
| The makefile will not work on Windows with MSVC. Not tested with neither CygWin nor MinGw. Execute the following instead: | ||
| ``` | ||
| python setup.py install boost-location=<path_to_your_boost> |
There was a problem hiding this comment.
The hyphens before the argument are missing.
| ``` | ||
| python setup.py install boost-location=<path_to_your_boost> | ||
| ``` | ||
|
|
||
| Testing | ||
| ------- | ||
|
|
There was a problem hiding this comment.
Please also add instructions on how to run the tests and build the documentation on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables installation of this package on Windows using MSVC compiler.
This involves two things:
setup.pyinto which CGAL will get unzipped, because MSVC expects it in a slightly different locationvisibility.cppto prevent linker errors on MSVCThe changes should not affect compilation on Linux and MacOS at all.