Skip to content

Commit

Permalink
removed jupyter as and explicit dependency from setup.py since it cre…
Browse files Browse the repository at this point in the history
…ated a version conflict with jupyterlab higher up (in the bgc_md2) dependencies. Since jupyter is often used together with the package but not strictly required this is a bit less error prone. It can still be installed of cause. Additionally I changed the conda channel to conda-forge which is the open source repo of conda and necessary for many of our dependencies anyway. It is not strictly necessary to avoid mixing of conda channels but sticking to one repo might decrease the chance of untested package combinations since the maintainers of the channels probably run integration tests for their channels but cannot be expected to do this for cross channel dependencies.
  • Loading branch information
mamueller committed Jul 20, 2021
1 parent 70b7b24 commit 81080fc
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion install_developer_conda.bat
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
call conda install -y --file requirements.developer
call conda install -c conda-forge -y --file requirements.developer
call python setup.py develop
2 changes: 1 addition & 1 deletion install_developer_conda.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
conda install -y --file requirements.developer
conda install -y --file requirements.developer -c conda-forge
python3 setup.py develop
2 changes: 0 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ def readme():
# setuptools should not be bothered with explicit versions, those will be specified in
# for pip in requirements.txt
install_requires=[
"concurrencytest",
"jupyter",
"matplotlib",
"mpmath",
"numpy",
Expand Down

0 comments on commit 81080fc

Please sign in to comment.