Skip to content

Commit

Permalink
Merge pull request #479 from MRChemSoft/fix-476
Browse files Browse the repository at this point in the history
Only validate cavity when doing PCM
  • Loading branch information
Gabrielgerez committed Feb 6, 2024
2 parents a1c6199 + c1a5213 commit 4b6acfe
Showing 1 changed file with 20 additions and 19 deletions.
39 changes: 20 additions & 19 deletions python/mrchem/validators.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,6 @@ def __init__(self, user_dict, origin):
self.do_translate = self.user_mol["translate"]
self.coords_raw = self.user_mol["coords"]

# Cavity related data
self.cavity_dict = user_dict["PCM"]["Cavity"]
self.cavity_mode = self.cavity_dict["mode"]
self.spheres_raw = self.cavity_dict["spheres"]
self.cavity_alpha = self.cavity_dict["alpha"]
self.cavity_beta = self.cavity_dict["beta"]
self.cavity_sigma = self.cavity_dict["sigma"]

# Validate atomic coordinates
(
self.atomic_symbols,
Expand All @@ -147,16 +139,25 @@ def __init__(self, user_dict, origin):
if self.unit == self.UNIT_ANGSTROM:
self.atomic_coords = self.ang2bohr_array(self.atomic_coords)

# Validate cavity spheres
# dimensioned quantities (cavity_radii, cavity_coords, cavity_sigmas)
# are _already_ converted to atomic units
(
self.cavity_radii,
self.cavity_coords,
self.cavity_alphas,
self.cavity_betas,
self.cavity_sigmas,
) = self.validate_cavity()
# Cavity related data
if user_dict["WaveFunction"]["environment"].lower() == "pcm":
self.cavity_dict = user_dict["PCM"]["Cavity"]
self.cavity_mode = self.cavity_dict["mode"]
self.spheres_raw = self.cavity_dict["spheres"]
self.cavity_alpha = self.cavity_dict["alpha"]
self.cavity_beta = self.cavity_dict["beta"]
self.cavity_sigma = self.cavity_dict["sigma"]

# Validate cavity spheres
# dimensioned quantities (cavity_radii, cavity_coords, cavity_sigmas)
# are _already_ converted to atomic units
(
self.cavity_radii,
self.cavity_coords,
self.cavity_alphas,
self.cavity_betas,
self.cavity_sigmas,
) = self.validate_cavity()

# Perform some sanity checks
self.check_for_nuclear_singularities()
Expand Down Expand Up @@ -353,7 +354,7 @@ def validate_cavity(self):

if radii_not_found:
raise ValueError(
f"vdw-radius for {', '.join(radii_not_found)} not defined in the Mantina set."
f"vdw-radius for {', '.join(radii_not_found)} not defined in the Mantina set. You should specify them in your input file."
)

alphas = [self.cavity_alpha] * len(radii)
Expand Down

0 comments on commit 4b6acfe

Please sign in to comment.