Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: CMAKE_SOURCE_DIR -> PROJECT_SOURCE_DIR #123

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

stigrj
Copy link
Contributor

@stigrj stigrj commented Jan 30, 2020

${CMAKE_SOURCE_DIR}/VERSION picks up the host version file in a super build

@stigrj stigrj requested a review from robertodr January 30, 2020 12:55
@MinazoBot
Copy link

1 Warning
⚠️ There are code changes, but no corresponding tests. Please include tests if this PR introduces any modifications in behavior.

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   72.15%   72.15%           
=======================================
  Files         139      139           
  Lines        5966     5966           
=======================================
  Hits         4305     4305           
  Misses       1661     1661

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d05e569...652abe3. Read the comment docs.

@robertodr robertodr merged commit cf8fbcd into MRChemSoft:master Jan 30, 2020
@stigrj stigrj deleted the cmake-bug branch March 11, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants