Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add convenience constructor for BoundingBox and MRA #179

Merged
merged 3 commits into from
Oct 11, 2021

Conversation

stigrj
Copy link
Contributor

@stigrj stigrj commented Oct 10, 2021

Accepts [0,L] or [-L,L] arguments for world size, where L must be a positive integer.

Accepts [0,L] or [-L,L] arguments for world size.
@codecov
Copy link

codecov bot commented Oct 10, 2021

Codecov Report

Merging #179 (64391f3) into master (268d238) will decrease coverage by 0.20%.
The diff coverage is 5.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   65.60%   65.39%   -0.21%     
==========================================
  Files         172      172              
  Lines       12441    12479      +38     
==========================================
- Hits         8162     8161       -1     
- Misses       4279     4318      +39     
Impacted Files Coverage Δ
src/trees/BoundingBox.h 100.00% <ø> (ø)
src/trees/MultiResolutionAnalysis.cpp 65.47% <0.00%> (-8.85%) ⬇️
src/trees/MultiResolutionAnalysis.h 87.50% <ø> (-12.50%) ⬇️
src/trees/BoundingBox.cpp 81.21% <6.66%> (-14.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 268d238...64391f3. Read the comment docs.

@robertodr
Copy link
Contributor

Isn't explicit only needed for 1-argument CTORs?

@stigrj
Copy link
Contributor Author

stigrj commented Oct 11, 2021

These are all single argument with the defaults, no?

@robertodr
Copy link
Contributor

Yes they are 😅

@robertodr robertodr merged commit dcbad5b into MRChemSoft:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants