Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix AnalyticAdaptor #184

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Bugfix AnalyticAdaptor #184

merged 1 commit into from
Oct 13, 2021

Conversation

stigrj
Copy link
Contributor

@stigrj stigrj commented Oct 13, 2021

Before we were capturing and passing on raw data from an rvalue.

This fixes the macos failed build on GHA.

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #184 (84082bf) into master (1aa9ef0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   65.55%   65.55%           
=======================================
  Files         172      172           
  Lines       12506    12506           
=======================================
  Hits         8198     8198           
  Misses       4308     4308           
Impacted Files Coverage Δ
src/treebuilders/AnalyticAdaptor.h 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aa9ef0...84082bf. Read the comment docs.

@stigrj stigrj force-pushed the testing branch 2 times, most recently from 4c6e338 to 51cde16 Compare October 13, 2021 13:47
@stigrj stigrj changed the title Trying to backtrack the macos fail Bugfix AnalyticAdaptor Oct 13, 2021
@stigrj stigrj requested a review from robertodr October 13, 2021 14:24
@robertodr robertodr merged commit 384b2c5 into MRChemSoft:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants