Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
The setter for
LensUpdateMode
does not work currently, as it is trying to setOpticStudioSystem.LensUpdateMode
rather than 'OpticStudioSystem.UpdateMode. There is some ambiguity as the contact is called 'LensUpdateMode
but the ZOS-API calls itUpdateMode
. For now, I think we should at least fix 'LensUpdateMode'.We can also choose to add 'UpdateMode' and drop LensUpdateMode), but that would be a breaking change. If we would want that, I would propose to fix LensUpdateMode for now, add
UpdateMode
and add a deprecation warning toLensUpdateMode
. I would like some input on that.Type of change
Additional information
Related issues
Checklist
If you contributed an analysis:
AttrDict
s for the analysis result data (please use dataclasses instead).If you contributed an example: