Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported locale exception on import #69

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Conversation

crnh
Copy link
Collaborator

@crnh crnh commented Mar 7, 2024

Proposed change

Use locale.setlocale(locale.LC_NUMERIC) instead of locale.getlocale() to determine the locale in zospy.api.config.

Type of change

  • Example (a notebook demonstrating how to use ZOSPy for a specific application)
  • Bugfix (non-breaking change which fixes an issue)
  • New analysis (a wrapper around an OpticStudio analysis)
  • New feature (other than an analysis)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation (improvement of either the docstrings or the documentation website)

Additional information

  • Python version: 3.9-3.12
  • OpticStudio version: 2024 R1

Related issues

Closes #66

Checklist

  • I have followed the contribution guidelines
  • The code has been linted, formatted and tested locally using tox.
  • Local tests pass. Please fix any problems before opening a PR. If this is not possible, specify what doesn't work and why you can't fix it.
  • I added new tests for any features contributed, or updated existing tests.
  • I updated CHANGELOG.md with my changes (except for refactorings and changes in the documentation).

If you contributed an analysis:

  • I did not use AttrDicts for the analysis result data (please use dataclasses instead).

If you contributed an example:

  • I contributed my example as a Jupyter notebook.

@crnh crnh added the bug Something isn't working label Mar 7, 2024
@crnh crnh requested a review from jwmbeenakker March 7, 2024 15:55
@crnh crnh merged commit 2e44c8e into main Mar 7, 2024
19 checks passed
@crnh crnh deleted the crnh_fix_locale_issues branch March 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

locale.setlocale raising exception
2 participants