Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What to do about spaces in header entries with spaces in keys? #1633

Open
jdtournier opened this issue Jun 27, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@jdtournier
Copy link
Member

commented Jun 27, 2019

This affects images produced by fixelcfestats, as discussed here.

I think we'll need to improve the MatLab handling (clearly there's no issues with handling these within the C++ code), but I also think it might be better to avoid spaces in key names in general, and modify fixelcfestats to avoid spaces in the first place. This should be OK to do, as far as I can tell, these headers entries are not queried anywhere else in the code.

Thoughts?

@jdtournier jdtournier added the bug label Jun 27, 2019

@jdtournier jdtournier added this to the MRtrix3 3.0 release milestone Jun 27, 2019

@jdtournier jdtournier self-assigned this Jun 27, 2019

@Lestropie

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

I'd do both: Fix the MatLab handling on master, and remove the the spaces from header keys at write time on dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.