Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DICOM: be more lenient with slice timing vector in Siemens mosaics #1499

Merged
merged 3 commits into from
Nov 27, 2018
Merged

DICOM: be more lenient with slice timing vector in Siemens mosaics #1499

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5449fe8
DICOM: be more lenient with slice timing vector is Siemens mosaics
jdtournier Nov 26, 2018
17af358
Merge remote-tracking branch 'github/master' into tmp
jdtournier Nov 26, 2018
95facfc
Merge branch 'master' into dicom_fix_slice_timing_mismatch_in_mosaic
thijsdhollander Nov 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions core/file/dicom/mapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,13 +211,13 @@ namespace MR {
// Slice timing may come from a few different potential sources
vector<float> slices_timing;
if (image.images_in_mosaic) {
if (image.mosaic_slices_timing.size() != image.images_in_mosaic) {
WARN ("Number of entries in mosaic slice timing (" + str(image.mosaic_slices_timing.size()) + ") does not match number of images in mosaic (" + str(image.images_in_mosaic) + "); omitting");
if (image.mosaic_slices_timing.size() < image.images_in_mosaic) {
WARN ("Number of entries in mosaic slice timing (" + str(image.mosaic_slices_timing.size()) + ") is smaller than number of images in mosaic (" + str(image.images_in_mosaic) + "); omitting");
} else {
DEBUG ("Taking slice timing information from CSA mosaic info");
// CSA mosaic defines these in ms; we want them in s
for (auto f : image.mosaic_slices_timing)
slices_timing.push_back (0.001 * f);
for (size_t n = 0; n < image.images_in_mosaic; ++n)
slices_timing.push_back (0.001 * image.mosaic_slices_timing[n]);
}
} else if (std::isfinite (frame.time_after_start)) {
DEBUG ("Taking slice timing information from CSA TimeAfterStart field");
Expand Down