Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No outer mzQC element #14

Closed
bittremieux opened this issue Jun 2, 2021 · 3 comments
Closed

No outer mzQC element #14

bittremieux opened this issue Jun 2, 2021 · 3 comments

Comments

@bittremieux
Copy link

Serializing an MzQCFile object doesn't include the outer mzQC tag. I.e. the generated result is:

{"creationDate": "2021-06-01T17:08:20",
 "version": "1.0.0",
 "runQualities": [],
 "setQualities": [],
 "controlledVocabularies": [{"name": "Proteomics Standards Initiative Quality Control Ontology", "uri": "https://raw.githubusercontent.com/HUPO-PSI/mzQC/master/cv/qc-cv.obo", "version": "0.1.2"}, {"name": "Proteomics Standards Initiative Mass Spectrometry Ontology", "uri": "https://raw.githubusercontent.com/HUPO-PSI/psi-ms-CV/master/psi-ms.obo", "version": "4.1.53"}]
}

And should be:

{"mzQC": {
    "creationDate": "2021-06-01T17:08:20",
    "version": "1.0.0",
    "runQualities": [],
    "setQualities": [],
    "controlledVocabularies": [{"name": "Proteomics Standards Initiative Quality Control Ontology", "uri": "https://raw.githubusercontent.com/HUPO-PSI/mzQC/master/cv/qc-cv.obo", "version": "0.1.2"}, {"name": "Proteomics Standards Initiative Mass Spectrometry Ontology", "uri": "https://raw.githubusercontent.com/HUPO-PSI/psi-ms-CV/master/psi-ms.obo", "version": "4.1.53"}]}
}
mwalzer added a commit that referenced this issue Mar 7, 2022
@mwalzer
Copy link
Contributor

mwalzer commented Mar 7, 2022

fix in 28e3629

@mwalzer
Copy link
Contributor

mwalzer commented Mar 7, 2022

PR for RC coming tomorrow (probably)

@mwalzer
Copy link
Contributor

mwalzer commented Mar 11, 2022

fix now in main

@mwalzer mwalzer closed this as completed Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants