Addition of IsoTech milliK resource class #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docstrings now use reStructured Text. set rstrip to True. added TYPE_CHECKING for all class methods. separated configure and read commands to allow different configurations for each channel. multiple readings may be taken by read_channel (in which case the method returns a list of floats instead of a single float). changed close_connection to instead modify the inherited disconnect method
jborbely
reviewed
Mar 28, 2024
docstrings improved for clarity and typographical, syntax and build errors fixed; simplified list iteration in example; unnecessary statements removed
and allowed each channel to be configured and read independently
jborbely
reviewed
Apr 10, 2024
read requires sending configuration of sense parameters immediately before or together with the read command. This fix somehow fixed the strange double read too. Also added a second example for a milliK connected by ethernet.
rebeccahawke
commented
Apr 11, 2024
channels and readings are returned as separate lists
jborbely
requested changes
Apr 11, 2024
and created local variable for channels to ensure consistency of ordering
jborbely
reviewed
Apr 12, 2024
| unless False in which case it uses root2*1 mA to determine self-heating effects. | ||
| Thermistors always use 2 μA. | ||
| :param fourwire: The wiring arrangement eg 3 or 4 wire. | ||
| :return: Returns the internal values set for range, current, and wiring. |
There was a problem hiding this comment.
This method now returns None so the :return: line should be deleted.
There was a problem hiding this comment.
OK, well spotted!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IsoTech milliK resource class can be used to read resistance values from a milliK and any number of connected millisKanner devices. The class supports measurement of PRTs and/or thermistors. Voltage measurement (e.g. for thermocouples) will need a subsequent update.