Addition of Vaisala resources #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docstrings now use reStructured Text. set rstrip to True. added TYPE_CHECKING for all class methods. separated configure and read commands to allow different configurations for each channel. multiple readings may be taken by read_channel (in which case the method returns a list of floats instead of a single float). changed close_connection to instead modify the inherited disconnect method
docstrings improved for clarity and typographical, syntax and build errors fixed; simplified list iteration in example; unnecessary statements removed
and allowed each channel to be configured and read independently
read requires sending configuration of sense parameters immediately before or together with the read command. This fix somehow fixed the strange double read too. Also added a second example for a milliK connected by ethernet.
channels and readings are returned as separate lists
and created local variable for channels to ensure consistency of ordering
# Conflicts: # tests/resources/test_init.py
using a dictionary 'desired_units' of quantities and units
jborbely
reviewed
May 16, 2024
removed log messages; adjusted behaviour of device_info, check_serial, and set_units; fixed docstring rendering; added default RS232 connection properties.
jborbely
reviewed
May 20, 2024
| * Pressure quantities: P, P3h, P1, P2, QNH, QFE, HCP, ... | ||
| * Pressure units: hPa, psi, inHg, torr, bar, mbar, mmHg, kPa, Pa, mmH2O, inH2O | ||
| * Temperature quantities: T, TP1, TP2, TP3, ... | ||
| * Temperature units: 'C, 'F, or K |
There was a problem hiding this comment.
In the PTU300 class, the leading ' (single quote) is not required for a temperature unit but here it is required. It may be useful to support C, F (no single quote) here for consistency with PTU300. Or always force the user to use a ' in both classes.
There was a problem hiding this comment.
Great suggestion. I've made some changes to catch incorrect unit setting for both classes.
typo fixes; simplified list representations; fixed errors in temperature unit setting; used Python unpacking feature; removed obsolete function return; changed PTU30* regex to specify supported models.
specified supported models for PTU300 class in docs. Added default RS232 connection info to class docstring.
jborbely
requested changes
May 27, 2024
There was a problem hiding this comment.
Two comments (in addition to my nitpicky comment):
- the docstring for
PTU300.get_format()does not render the backslash properly. Just make the dosctring a raw string (leadingr), e.g.,r"""Return the currently...""" - rename the argument
formatto befmtinPTU300.set_format()since it's best to avoid using builtin names when possible.
fixed docstring rendering and typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two equipment classes are included, for two types of barometer: PTU300 and PTB330.