Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup msv?VTKButtons??? #14

Open
finetjul opened this issue Jan 4, 2013 · 0 comments
Open

Cleanup msv?VTKButtons??? #14

finetjul opened this issue Jan 4, 2013 · 0 comments
Assignees
@alosi
Labels
architecture buttons style

Comments

@finetjul
Copy link
Member

finetjul commented Jan 4, 2013

a) Minor design changes have been suggested as comments here: 04ff834

b) Apply MSVTK style to code:

  • 2 space for indentation
  • prefer SafeDownCast to reinterpret_cast/static_cast
  • Use Superclass to mother class calls
  • Prefer pre-increment over post-increment (++i instead of i++)
  • #ifndef/#define follow the convention __filename_h
  • Add space after if and for
@ghost ghost assigned alosi Jan 4, 2013
finetjul added a commit that referenced this issue Jan 4, 2013
@finetjul
Apply MSVTK style to code
d5df644 
* 2 space for indentation
* prefer ```SafeDownCast``` to reinterpret_cast/static_cast
*  Use Superclass to mother class calls
*  Prefer pre-increment  over post-increment (```++i``` instead of ```i++```)
* ```#ifndef```/```#define``` follow the convention ```__filename_h```
* Add space after ```if``` and ```for```

Issue #14
alosi pushed a commit that referenced this issue Jan 24, 2013
Some design changes (issue #14)
e2be5bb
alosi pushed a commit that referenced this issue Jan 24, 2013
Merge branch 'Issue#14'
a2c99ea 
* Issue#14:
  Some design changes (issue #14)
alosi pushed a commit that referenced this issue Jan 24, 2013
Some design changes (issue #14)
3e6b288
alosi pushed a commit that referenced this issue Jan 24, 2013
Merge branch 'Issue#14'
3ce954c 
* Issue#14:
  Some design changes (issue #14)
alosi pushed a commit that referenced this issue Jan 24, 2013
Some fix on coding style (issue #14)
34bb95d
alosi pushed a commit that referenced this issue Jan 24, 2013
Merge branch 'Issue#14'
14d8fb7 
* Issue#14:
  Some fix on coding style (issue #14)
alosi pushed a commit that referenced this issue Jan 24, 2013
Some fix on coding style (issue #14)
d8c99e4
alosi pushed a commit that referenced this issue Jan 24, 2013
Merge branch 'Issue#14'
0a93e89 
* Issue#14:
  Some fix on coding style (issue #14)
alosi pushed a commit that referenced this issue Jan 24, 2013
Some fix on coding style (issue #14)
da981d9
alosi pushed a commit that referenced this issue Jan 24, 2013
Merge branch 'Issue#14'
3d2f600 
* Issue#14:
  Some fix on coding style (issue #14)
alosi pushed a commit that referenced this issue Jan 24, 2013
Fix compile error under windows (issue #14)
717bcb5
alosi pushed a commit that referenced this issue Jan 24, 2013
Merge branch 'fixVS2010CompileErrors'
c888b73 
* fixVS2010CompileErrors:
  Fix compile error under windows (issue #14)
alosi pushed a commit that referenced this issue Jan 24, 2013
Add widget export to vtk button manager (issue #14)
ffa6753
alosi pushed a commit that referenced this issue Jan 24, 2013
Merge branch 'fixVS10LinkErrors'
be7ac42 
* fixVS10LinkErrors:
  Add widget export to vtk button manager (issue #14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alosi alosi

Labels
architecture buttons style
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@finetjul @alosi