add testing #4
Merged
add testing #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgbkrk
reviewed
Apr 30, 2022
| IN_IPYTHON_ENV = get_ipython() is not None | ||
| if IN_IPYTHON_ENV: | ||
| DEFAULT_IPYTHON_DISPLAY_FORMATTER = get_ipython().display_formatter | ||
|
|
rgbkrk
reviewed
Apr 30, 2022
dx/tests/conftest.py
Outdated
| "image/jpeg": formatters.JPEGFormatter(), | ||
| "image/png": formatters.PNGFormatter(), | ||
| "image/svg+xml": formatters.SVGFormatter(), | ||
| } |
There was a problem hiding this comment.
You don't have to but I think it's fine to reduce the total set here in the tests since you only need text/html, application/vnd.dataresource+json, text/plain, and the dex media type.
rgbkrk
reviewed
Apr 30, 2022
dx/tests/test_formatters.py
Outdated
| assert len(data) == len(fields) | ||
|
|
||
|
|
||
| # # TODO: mock IPython environment's display formatter |
There was a problem hiding this comment.
The IPython tests use this in their conftest.py (note: I edited this to work in a local script):
from IPython.testing import tools
def get_ipython():
from IPython.terminal.interactiveshell import TerminalInteractiveShell
if TerminalInteractiveShell._instance:
return TerminalInteractiveShell.instance()
config = tools.default_config()
config.TerminalInteractiveShell.simple_prompt = True
# Create and initialize our test-friendly IPython instance.
shell = TerminalInteractiveShell.instance(config=config)
return shellAs an example:
$ cat ipy.py
from IPython.testing import tools
def get_ipython():
from IPython.terminal.interactiveshell import TerminalInteractiveShell
if TerminalInteractiveShell._instance:
return TerminalInteractiveShell.instance()
config = tools.default_config()
config.TerminalInteractiveShell.simple_prompt = True
# Create and initialize our test-friendly IPython instance.
shell = TerminalInteractiveShell.instance(config=config)
return shell
print(get_ipython().display_formatter.format("a simple script"))
$ python ipy.py
({'text/plain': "'a simple script'"}, {})
… instance in a better way
rgbkrk
reviewed
May 3, 2022
| """Reverts IPython.display_formatter to its original state""" | ||
| if not IN_IPYTHON_ENV and ipython_shell is None: | ||
| return |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some basic unit tests focused around the output structure from
format_dx()Handles imports and testing for non-IPython environments
dx.format_dx(df)