Closes #47 - updated datatype handling - Decimal, datetime.date, datetime.time #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e() arguments and add decimal_column/date_column/time_column
shouples
changed the title
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
- Coverage 86.92% 83.24% -3.69%
==========================================
Files 19 24 +5
Lines 1132 1253 +121
==========================================
+ Hits 984 1043 +59
- Misses 148 210 +62
Continue to review full report at Codecov.
|
….display() on an object that goes through handle_format()
jlrobins
approved these changes
Oct 13, 2022
shouples
added a commit
that referenced
this pull request
Nov 14, 2022
…time.time (#70) * add Decimal handler and generator functions; clean up random_dataframe() arguments and add decimal_column/date_column/time_column * add datetime.date and datetime.time generators and handlers * check for and handle decimals and datetime.dates by default * return gpd.GeoSeries instead of GeometryArray * add boolean series generator option * add datatype imports with new directory structure * ignore flake8 C901 - "too complex" * add datatype compatibility helpers * add optional with_ipython_display argument to prevent calling IPython.display() on an object that goes through handle_format()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright, so this is another "probably should've been multiple PRs" scenario. The overall theme here is "making it easier to handle or prepare for new/non-standard data types" with the display formatting.
decimal.Decimal,datetime.date,datetime.timetypesdatatypes.pyinto a separatedatatypesdirectory for easier future developmentdatatypes/main.pyhandles the top-level dataframe generation with available datatype generator helpers per column toggleddatatypesare grouped intonumeric/date_time/text/geometry/miscdatatypes/compatibility.py::test_compatibilityto throw new data types and see which parts of the pipeline may break (betweenpandas.io.json.build_table_schema,duckdb conn.register(),jupyter_client.jsonutil.json_clean, or all ofdx.handle_format)